Conversation
…button in onboarding Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
yujonglee
deleted the
devin/1771813643-calendar-request-access-button
branch
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| <div className="flex flex-col gap-4"> | ||
| <ApplePermissions /> | ||
|
|
||
| <SyncProvider> | ||
| <AppleCalendarList /> | ||
| </SyncProvider> | ||
| {isAuthorized ? ( | ||
| <SyncProvider> | ||
| <AppleCalendarList /> | ||
| </SyncProvider> | ||
| ) : ( | ||
| <RequestCalendarAccess | ||
| onRequest={calendar.request} | ||
| isPending={calendar.isPending} | ||
| /> | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
🚩 Duplicate permission request UI when calendar is not authorized
When isAuthorized is false, both ApplePermissions (line 56) and RequestCalendarAccess (lines 62-65) are rendered simultaneously. ApplePermissions (apps/desktop/src/components/main/body/calendar/apple/permission.tsx:10-25) already renders an AccessPermissionRow with a request button for calendar permission. The new RequestCalendarAccess component adds a second, separate "Request Access to Calendar" button in the area where the calendar list would normally appear.
This means the user sees two different ways to request calendar access at the same time. Compare with apps/desktop/src/components/main/body/calendar/sidebar.tsx:62-93 where the permission row and the calendar list are shown conditionally — the permission row is hidden once authorized, and the calendar list replaces it. The onboarding flow doesn't follow this same pattern.
This may be intentional (permission row for status/troubleshooting, button as a clear CTA), but it's worth confirming the design intent.
(Refers to lines 54-68)
Was this helpful? React with 👍 or 👎 to provide feedback.
2 participants
Summary
In the onboarding Calendar tab, when the user hasn't granted calendar permission yet, the app previously showed an empty
CalendarSelectionwith "No calendars found." This replaces that empty state with a dedicated "Request Access to Calendar" button.RequestCalendarAccesscomponent with a calendar icon and outline buttonusePermission("calendar")status inCalendarSectionAppleCalendarList) when permission is authorized; otherwise renders the request buttonReview & Testing Checklist for Human
ApplePermissions(the red "Calendar" row with arrow button) is still rendered above the newRequestCalendarAccessbutton. Both triggercalendar.request. Verify this is the intended design, or ifApplePermissionsshould be hidden/simplified when not yet authorized.Notes
CalendarSelection"No calendars found" empty state is unchanged — it just won't be reachable during onboarding anymore since we gate on permission status first.usePermission("calendar")is called unconditionally inCalendarSectioneven on non-macOS, but the result is only used inside theisMacosbranch, so no functional impact.Requested by: @goranmoomin
Link to Devin run